tools: Add github.com/mgechev/revive #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7472 +/- ##
==========================================
+ Coverage 81.38% 81.51% +0.12%
==========================================
Files 354 357 +3
Lines 27080 27242 +162
==========================================
+ Hits 22040 22207 +167
+ Misses 3831 3826 -5
Partials 1209 1209 |
purnesh42H
force-pushed
the
add-revive-linter
branch
from
d3a4963 to
20f6b61
Compare
purnesh42H
changed the title
purnesh42H
force-pushed
the
add-revive-linter
branch
6 times, most recently
from
69ef453 to
1880907
Compare
purnesh42H
force-pushed
the
add-revive-linter
branch
from
1880907 to
5ae9cd3
Compare
purnesh42H
force-pushed
the
add-revive-linter
branch
from
6a8de80 to
941218f
Compare
dfawley
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Tactically speaking...
Warnings:
546 unused-parameter
83 exported
28 var-naming
15 redefines-builtin-id
8 package-comments
8 empty-block
6 var-declaration
3 indent-error-flow
2 increment-decrement
1 context-as-argument
1 superfluous-else
...we're going to want to fix the issues that have few instances of them ASAP. But we will probably want to make this a blocking checker before fixing all the "unused-parameter" items, since there are so many of them.
dfawley
reviewed
Aug 1, 2024
scripts/vet.sh
Outdated
Comment on lines
171
to
175
| # - Collection of revive linter analysis checks | ||
| REV_OUT="$(mktemp)" | ||
| revive -formatter unix ./... >"${REV_OUT}" || true | ||
|
|
||
| (noret_grep -v "[unused-parameter]" "${REV_OUT}" | not grep -v "\.pb\.go:") || true |
There was a problem hiding this comment.
Now this doesn't show us the other errors.
Maybe we can just make revive skip that check? I assume that's possible?
There was a problem hiding this comment.
After switching to plain formatter, it works
purnesh42H
force-pushed
the
add-revive-linter
branch
from
0d56a0c to
d7dfb68
Compare
purnesh42H
force-pushed
the
add-revive-linter
branch
from
d7dfb68 to
b8af6c4
Compare
dfawley
approved these changes
Aug 1, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #7444
RELEASE NOTES: None