xds/balancer/priority: Unlock mutex before returning #7417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7417 +/- ##
==========================================
- Coverage 81.42% 81.33% -0.09%
==========================================
Files 348 350 +2
Lines 26744 26846 +102
==========================================
+ Hits 21775 21834 +59
- Misses 3779 3809 +30
- Partials 1190 1203 +13
|
dfawley
approved these changes
Jul 15, 2024
Calling a |
dfawley
changed the title
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
printchard
pushed a commit
to printchard/grpc-go
that referenced
this pull request
Jul 30, 2024
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release the mutex that is locked a couple of lines above.
grpc-go/xds/internal/balancer/priority/balancer.go
Lines 271 to 274 in d27ddb5
This could subsequent calls to
UpdateClientConnStateto get stuck.RELEASE NOTES: None