The committers listed above are authorized under a signed CLA.

• ✅ login: infovivek2020 (c26c5bd, 6189b10, f6548aa, f71b71d, 6da4004, 7e61a1e, ed501a9, bd7f205, d9a3efc)

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.55%. Comparing base (ee62e56) to head (d9a3efc).

@@            Coverage Diff             @@
##           master    #7392      +/-   ##
==========================================
+ Coverage   81.50%   81.55%   +0.05%     
==========================================
  Files         348      348              
  Lines       26752    26752              
==========================================
+ Hits        21804    21818      +14     
+ Misses       3766     3757       -9     
+ Partials     1182     1177       -5     

@purnesh42H previous PR #7362 do consider this one
Do assign me as assignee

Thanks @infovivek2020. LGTM. Please take a look at some of the other submitted PRs and add RELEASE NOTES section in your PR description as part of Mergeable check

@infovivek2020 can you comment on the issue #7350 that you have raised a PR for this so that I can assign it to you

@infovivek2020 just a reminder to add RELEASE NOTES in the PR description so that we can go ahead and merge

@infovivek2020 don't edit changelog.md. In your PR description, you can mention "RELEASE NOTES: N/A"

@infovivek2020 : Could you please sign the CLA.

@purnesh42H right now i am facing "HEAD is now at 0dfcf4e Merge c26c5bd into daab563
Error: Process completed with exit code 1."

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

This PR affects codegen, so it should regenerate everything regardless.

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

Not very important, but relevant for this PR.

This #7351 introduce support for editions. However our regenerate scripts is broken complaining something like this:

protoc-gen-go: invalid FileDescriptorProto "examples/route_guide/routeguide/route_guide.proto": proto: invalid syntax: "editions"

I'm investigating this. Let me see if I get some time to fix this today.

@arvindbr8 is the vet issue fixed? Do we have to regenerate the protos again?

This PR affects codegen, so it should regenerate everything regardless.

yeah I mean the protos are regenerated but do we have to regenerate again after Arvind's fix?

@infovivek2020 can you pull and rebase your branch on latest upstream and then run ./scripts/regenerate.sh again?

@infovivek2020 looks like you got unwanted files in your push. Can you try following

1. git checkout master
2. git pull upstream master
3. git rebase upstream/master
4. git checkout "your branch"
5. git rebase master
6. git push --force

@dfawley this looks good to be merged