github: update codecov with token and fail_ci_if_error #7348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's watch how https://github.com/grpc/grpc-go/actions/runs/9652389393/job/26622423791?pr=7348 goes |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7348 +/- ##
==========================================
+ Coverage 80.58% 81.39% +0.80%
==========================================
Files 349 348 -1
Lines 34056 26761 -7295
==========================================
- Hits 27445 21781 -5664
+ Misses 5431 3786 -1645
- Partials 1180 1194 +14 |
|
That didnt work; I updated codecov to v4 and now it works: https://github.com/grpc/grpc-go/actions/runs/9652538323/job/26622886451?pr=7348 |
dfawley
approved these changes
Jun 24, 2024
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none