-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
examples: Add CSM Observability example #7302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7302 +/- ##
==========================================
- Coverage 81.24% 80.54% -0.71%
==========================================
Files 345 348 +3
Lines 33941 33983 +42
==========================================
- Hits 27574 27370 -204
- Misses 5202 5422 +220
- Partials 1165 1191 +26 |
@@ -0,0 +1,30 @@ | |||
# CSM Observability | |||
|
|||
This examples shows how to configure CSM Observability for a binary, and shows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A hyperlink to CSM somewhere in this page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but the documentation is currently internal/confidential and there's no blog post about it yet or any public facing docs. Perhaps I can mention to refer to the CSM user guide?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment at the end of this paragraph. The UG is not published yet, will add a hyperlink once the public preview UG goes out.
Got to all comments; thank you for the pass. |
server applications (configured once per binary), and shows what type of | ||
telemetry data it can produce for certain RPCs with additional CSM Labels. The | ||
gRPC Client accepts configuration from an xDS Control plane as the default | ||
address that it connects to is "xds:///helloworld:50051", but this can be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I don't understand is how is this example supposed to work without the user running a management server, given that the default dial target has an xds
scheme.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comment about needing to run in Cloud Service Mesh.
Discussed this with Richard; will also backport this to 1.65.x. This is so the docker tag of the image I upload for User Guide can have a stable tag rather than the unstable @latest. |
This PR adds a CSM Observability example. This is not intended to be ran locally unless overwritten the address, the intended usage is to be built as docker images and deployed as part of the CSM user guide. This system will also have xDS Configuration as part of it, which will allow it to connect to upstream.
This is the same as #7296 expect it uses an xDS Target and configures OpenTelemetry using CSM Global Observability and not a specific Dial Option and Server Option.
RELEASE NOTES: