Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpcrand: delete all of grpcrand and call the rand package directly #7283

Merged
merged 1 commit into from
May 31, 2024

Conversation

arvindbr8
Copy link
Member

Some more cleanup after dropping support for go1.20 (#7249)

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Internal Cleanup Refactors, etc label May 30, 2024
@arvindbr8 arvindbr8 added this to the 1.65 Release milestone May 30, 2024
@arvindbr8 arvindbr8 requested a review from easwars May 30, 2024 05:58
@easwars
Copy link
Contributor

easwars commented May 31, 2024

Go1.22 introduced a new rand package with a lot of improvements. Should we use that instead?
See: https://go.dev/blog/randv2

@easwars easwars assigned arvindbr8 and unassigned easwars May 31, 2024
@dfawley
Copy link
Member

dfawley commented May 31, 2024

Go1.22 introduced a new rand package with a lot of improvements. Should we use that instead?

Not yet, unless it's so much better that it's worth doing conditionally on version. After 1.23 is released in a few months, we can use it.

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP grpcrand

@easwars
Copy link
Contributor

easwars commented May 31, 2024

Go1.22 introduced a new rand package with a lot of improvements. Should we use that instead?

Not yet, unless it's so much better that it's worth doing conditionally on version. After 1.23 is released in a few months, we can use it.

Then, maybe an issue to not lose track of it? The blog post does list a lot of improvements. Agree that some of those improvements have been back ported as well, but not all of them.

@arvindbr8
Copy link
Member Author

i agree to @dfawley - #7283 (comment).

Tracking this in issue: #7293

@arvindbr8 arvindbr8 merged commit 8bf2b3e into grpc:master May 31, 2024
11 checks passed
@arvindbr8 arvindbr8 deleted the remove_grpcrand branch May 31, 2024 18:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants