stats/opentelemetry: Add e2e testing for CSM Observability #7279
Conversation
|
Thanks for the pass! Got to all comments. |
Why are we doing this? |
|
The target attribute filter used to part of the OTel API, but was deleted as it was realized it was too much complexity: grpc/proposal#431. The method attribute filter I simply forgot to unit test. |
Please specify in the PR description. |
|
Thank you for the detailed pass! |
|
Thank you so much for the detailed pass, looks a lot cleaner now. Got to all comments. |
| } | ||
| } | ||
|
|
||
| func unaryInterceptorAttachxDSLabels(ctx context.Context, method string, req, reply any, cc *grpc.ClientConn, invoker grpc.UnaryInvoker, opts ...grpc.CallOption) error { |
There was a problem hiding this comment.
Whoops, missed this one.
|
Thank you for the detailed passes on this; this looks much better than when it started. |
This PR adds the e2e testing for CSM Observability. It refactors common logic shared with OpenTelemetry e2e tests into internal/testingutils.
Alongside this, this PR deletes the Target Attribute filter and adds a unit test for the method attribute filter. The target attribute filter used to be part of the OTel API, but was deleted as it was realized it was too much complexity for a use case we don't even know if users want: grpc/proposal#431. The method attribute filter I simply forgot to unit test.
RELEASE NOTES: