Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update dependencies for all modules #7274

Merged
merged 3 commits into from
May 29, 2024
Merged

Conversation

arvindbr8
Copy link
Member

RELEASE NOTES: none

@arvindbr8 arvindbr8 added the Type: Meta Github repo, process, etc label May 28, 2024
@arvindbr8 arvindbr8 requested a review from easwars May 28, 2024 17:53
@arvindbr8
Copy link
Member Author

arvindbr8 commented May 28, 2024

Need to resolve the test failures around adding toolchain to go.mod files. This is the state after running the command per our release steps. Need to check if we need to update it accordingly.

Seems like the test failure in the latest commit is related to a dep that we are pulling in. Checking this now.

@easwars
Copy link
Contributor

easwars commented May 28, 2024

Tests are all failing.

@arvindbr8 arvindbr8 added this to the 1.65 Release milestone May 28, 2024
@arvindbr8
Copy link
Member Author

Fixed the tests, For some reason go get -u ./... && go mod tidy -compat=1.19 did not update stats/otel to use otel/sdk/metric @ 1.27.

However running go mod tidy -compat=1.19 added toolchain to go.mod files -- which is not supported in 1.20. I'll just wait for #7250 to be merged to unblock this.

@arvindbr8 arvindbr8 closed this May 28, 2024
@arvindbr8 arvindbr8 reopened this May 28, 2024
@arvindbr8 arvindbr8 assigned easwars and unassigned arvindbr8 May 29, 2024
@arvindbr8 arvindbr8 merged commit 58cfe27 into grpc:master May 29, 2024
20 of 21 checks passed
@arvindbr8 arvindbr8 deleted the update_deps branch May 30, 2024 00:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Meta Github repo, process, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants