Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: fix typos #7178

Merged
merged 4 commits into from
May 2, 2024
Merged

*: fix typos #7178

merged 4 commits into from
May 2, 2024

Conversation

hakusai22
Copy link
Contributor

@hakusai22 hakusai22 commented May 2, 2024 •
edited by dfawley
Loading

fix typo

RELEASE NOTES: none

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 2, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@dfawley
Copy link
Member

dfawley commented May 2, 2024

Thanks for the PR.

Please revert the generated code (*.pb.go) as those are just copied from the source .proto file. If you want to fix those, too, they are in http://github.com/grpc/grpc-proto.

Also, what tool are you using for this? We may want to add it to our presubmit checks.

@hakusai22
Copy link
Contributor Author

Thanks for the PR.

Please revert the generated code (*.pb.go) as those are just copied from the source .proto file. If you want to fix those, too, they are in http://github.com/grpc/grpc-proto.

Also, what tool are you using for this? We may want to add it to our presubmit checks.

done. Thanks for the reply, I am using this tool https://github.com/crate-ci/typos

@hakusai22 hakusai22 changed the title fix typo fix: typo May 2, 2024
dfawley
dfawley approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

@dfawley dfawley changed the title fix: typo *: fix typos May 2, 2024
@dfawley dfawley added this to the 1.64 Release milestone May 2, 2024
@arvindbr8
Copy link
Member

Thanks. Very wholesome

@arvindbr8 arvindbr8 merged commit 273fe14 into grpc:master May 2, 2024
12 checks passed
@hakusai22 hakusai22 deleted the fix_typo branch May 3, 2024 04:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@hakusai22 hakusai22

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.64 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@hakusai22 @dfawley @arvindbr8