examples: fix the quickstart link in the routeguide example #7162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjan-bal
changed the title
arjan-bal
changed the title
|
@arjan-bal Just to double check, quickstart guide is updated and enough to generate the dependencies right? |
Yes, the prerequisites section of the guide has the instructions to install the required tools, mainly the go and grpc-go plugins for protoc. |
aranjans
reviewed
Apr 25, 2024
examples/gotutorial.md
Outdated
| @@ -28,7 +28,7 @@ Then change your current directory to `grpc-go/examples/route_guide`: | |||
| $ cd $GOPATH/src/google.golang.org/grpc/examples/route_guide | |||
| ``` | |||
|
|
|||
| You also should have the relevant tools installed to generate the server and client interface code - if you don't already, follow the setup instructions in [the Go quick start guide](https://github.com/grpc/grpc-go/tree/master/examples/). | |||
| You also should have the relevant tools installed to generate the server and client interface code - if you don't already, follow the setup instructions in [the Go quick start guide](https://grpc.io/docs/languages/go/quickstart). | |||
There was a problem hiding this comment.
Just following the other PR's review, shall we change this to something like
"Ensure you have the relevant tools installed to generate the server and client interface code. If you don't, follow the setup instructions in the Go quick start guide (https://grpc.io/docs/languages/go/quickstart)."
What do you think @arjan-bal?
There was a problem hiding this comment.
Yeah, it sounds better. Changed accordingly.
|
Thanks @arjan-bal. LGTM!. Pitching in @dfawley to have one more approval. |
dfawley
changed the title
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Point to the Go quickstart link which has the instructions for installing protoc and the required plugins.
RELEASE NOTES: none