Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark old CRL APIs as deprecated #6810

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Conversation

gtcooke94
Copy link
Contributor

@gtcooke94 gtcooke94 commented Nov 20, 2023

With the addition of the CRL Provider interface and implementations, these old CRL APIs should not be used anymore.

RELEASE NOTES: n/a

@gtcooke94 gtcooke94 added Type: Documentation Documentation or examples Type: Security A bug or other problem affecting security labels Nov 20, 2023
@gtcooke94 gtcooke94 added this to the 1.60 Release milestone Nov 20, 2023
@gtcooke94 gtcooke94 requested a review from dfawley November 20, 2023 16:49
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Merging #6810 (47d53a1) into master (7935c4f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6810      +/-   ##
==========================================
- Coverage   83.40%   83.36%   -0.04%     
==========================================
  Files         285      285              
  Lines       30879    30879              
==========================================
- Hits        25754    25742      -12     
- Misses       4053     4061       +8     
- Partials     1072     1076       +4     

see 18 files with indirect coverage changes

Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@gtcooke94 gtcooke94 merged commit 287c473 into grpc:master Nov 21, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples Type: Security A bug or other problem affecting security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants