Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolver_wrapper: remove serializerScheduleLocked; the lock is unnecessary #6803

Merged
merged 1 commit into from
Nov 15, 2023
Merged

resolver_wrapper: remove serializerScheduleLocked; the lock is unnecessary #6803

merged 1 commit into from
Nov 15, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Nov 15, 2023

RELEASE NOTES: n/a

@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Nov 15, 2023
@dfawley dfawley added this to the 1.61 Release milestone Nov 15, 2023
@dfawley dfawley requested a review from arvindbr8 November 15, 2023 22:56
@codecov Codecov
Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Merging #6803 (eb4fdf1) into master (914ca65) will increase coverage by 0.03%.
The diff coverage is 50.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6803      +/-   ##
==========================================
+ Coverage   83.48%   83.52%   +0.03%     
==========================================
  Files         285      285              
  Lines       30883    30879       -4     
==========================================
+ Hits        25784    25792       +8     
+ Misses       4032     4019      -13     
- Partials     1067     1068       +1
Files Coverage Δ
resolver_wrapper.go 94.64% <50.00%> (-0.19%) ⬇️

... and 15 files with indirect coverage changes

arvindbr8
arvindbr8 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arvindbr8 arvindbr8 assigned dfawley and unassigned arvindbr8 Nov 15, 2023
@dfawley dfawley merged commit 7935c4f into grpc:master Nov 15, 2023
14 checks passed
@dfawley dfawley deleted the reswrap branch November 15, 2023 23:20
dfawley added a commit to dfawley/grpc-go that referenced this pull request Dec 7, 2023
@dfawley
resolver_wrapper: remove serializerScheduleLocked; the lock is unnece…
7fbc125 
…ssary (grpc#6803)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@dfawley dfawley

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.61 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @arvindbr8