Set top-level read-only workflow permissions #6775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Signed-off-by: Pedro Kaj Kjellerup Nacht <pnacht@google.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6775 +/- ##
==========================================
- Coverage 83.40% 83.31% -0.10%
==========================================
Files 285 285
Lines 30966 30966
==========================================
- Hits 25828 25798 -30
- Misses 4068 4087 +19
- Partials 1070 1081 +11 |
arvindbr8
added
Type: Meta
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6774.
As mentioned in the issue, this PR adds top-level read-only permissions to
coverage.yml, ensuring it can't be used for supply-chain attacks on the repo.I've also made a few similar changes to the other workflows, mostly just setting
writepermissions at job-level instead of top-level. This serves to future-proof the workflows in case new jobs (that don't need those permissions) are added to the workflows. However, this change has no immediate impact to those workflows' security: the tokens effectively used in those jobs are unchanged.RELEASE NOTES: None