rpc_util: Fix RecvBufferPool deactivation issues
#6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Resolved unintended deactivation scenarios: - During unary RPC calls. - When compression is enabled. - Also corrected missing `payInfo.uncompressedBytes` in `Server.processUnaryRPC`.
|
This PR will fix #6578. |
dfawley
approved these changes
Feb 16, 2024
zasweq
changed the title
RecvBufferPool deactivation issuesRecvBufferPool deactivation issues
zasweq
requested changes
Feb 21, 2024
|
|
||
| const bufferCount = reqCount * 2 // req + resp | ||
| if len(pool.puts) != bufferCount { | ||
| t.Fatalf("Expected 10 buffers to be returned to the pool, got %d", len(pool.puts)) |
There was a problem hiding this comment.
bufferCount is 20. Should this say 20?
There was a problem hiding this comment.
Yes, and it's exactly twice the reqCount.
There was a problem hiding this comment.
Right, but the error message says 10 :). Switch to 20?
There was a problem hiding this comment.
Right, but the error message says 10 :). Switch to 20?
Got it! 389c89e
|
I'm going to go ahead and approve this, I'm going to be out the next few weeks so once you get to my minor nits one of my teammates can merge this. |
zasweq
approved these changes
Feb 22, 2024
dfawley
pushed a commit
that referenced
this pull request
Mar 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6578
Resolved unintended deactivation scenarios:
Also corrected missing
payInfo.uncompressedBytesinServer.processUnaryRPC.RELEASE NOTES: none