Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "alts: Reduce ALTS counter overflow length from 5 to 4." #6746

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Revert "alts: Reduce ALTS counter overflow length from 5 to 4." #6746

merged 1 commit into from
Oct 24, 2023

Conversation

matthewstevenson88
Copy link
Contributor

@matthewstevenson88 matthewstevenson88 commented Oct 24, 2023 •
edited by arvindbr8
Loading

Reverts #6699

This will break all ALTS Go connections as soon as they attempt to rekey.

RELEASE NOTES: none

@matthewstevenson88 matthewstevenson88 added the Type: Security A bug or other problem affecting security label Oct 24, 2023
@matthewstevenson88 matthewstevenson88 added this to the 1.60 Release milestone Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Merging #6746 (ec36b10) into master (7b8d0fd) will increase coverage by 0.21%.
The diff coverage is n/a.

Additional details and impacted files

@arvindbr8
Copy link
Member

@matthewstevenson88 -- could you add a note in the description for the reason for the revert?

@matthewstevenson88 matthewstevenson88 self-assigned this Oct 24, 2023
@matthewstevenson88 matthewstevenson88 added Type: Security A bug or other problem affecting security and removed Type: Security A bug or other problem affecting security labels Oct 24, 2023
@matthewstevenson88 matthewstevenson88 merged commit 6e14274 into master Oct 24, 2023
23 checks passed
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@matthewstevenson88 @arvindbr8
Revert "alts: Reduce ALTS counter overflow length from 5 to 4. (grpc#…
b2adc65 
…6699)" (grpc#6746)

This reverts commit 7b8d0fd.
@arvindbr8 arvindbr8 deleted the revert-6699-reduce-alts-overflow-limit branch November 7, 2023 17:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

@cesarghali cesarghali cesarghali approved these changes

Assignees

@matthewstevenson88 matthewstevenson88

Labels
Type: Security A bug or other problem affecting security
Projects
None yet
Milestone
1.60 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@matthewstevenson88 @arvindbr8 @cesarghali