Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Exposes underlying channel in testutils.Channel{} #6742

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

Aditya-Sood
Copy link
Contributor

Fixes #4662

RELEASE NOTES: none

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #6742 (cd58853) into master (e14d583) will increase coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

@Aditya-Sood
Copy link
Contributor Author

hi @zasweq @dfawley, I have a query about @easwars's comment to modify the tests in listener_wrapper_test.go:
the channels created by NewListenerWrapper() are directed "receive-only" channels, unlike the undirected channel stored in the testutils.Channel{} struct

is the expectation here to replace all the directed channels with an undirected one from testutils.Channel{}?

kindly let me know, thank you

@dfawley
Copy link
Member

dfawley commented Oct 19, 2023

I believe @easwars's comment just talking about how it may be able to be used more generally if the channel was exposed for direct access. Not that we must also update all the existing tests.

I would say for the purposes of the issue, this PR is sufficient. If you want to send follow-up PRs to make other existing tests use the testutils.Channel to simplify them, then that would be nice, too. Replacing a read-only channel with something bidirectional is fine since these are just tests.

@dfawley dfawley requested a review from arvindbr8 October 19, 2023 15:58
@dfawley dfawley added this to the 1.60 Release milestone Oct 19, 2023
@arvindbr8 arvindbr8 merged commit e88e849 into grpc:master Oct 19, 2023
13 checks passed
arvindbr8 pushed a commit to arvindbr8/grpc-go that referenced this pull request Nov 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose the underlying channel from testutils.Channel
3 participants