resolver/manual: support restarts, required for channel idleness #6638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
commented
Sep 15, 2023
dfawley
reviewed
Sep 15, 2023
resolver/manual/manual.go
Outdated
| r.UpdateState(*r.bootstrapState) | ||
| if r.lastSeenState != nil { | ||
| err := r.CC.UpdateState(*r.lastSeenState) | ||
| go func(err error) { r.UpdateStateCallback(err) }(err) |
There was a problem hiding this comment.
What's the concern about using go r.UpdateStateCallback(err)? err can't be modified after this.
There was a problem hiding this comment.
I think I was paranoid beyond repair :P
resolver/manual/manual.go
Outdated
| @@ -26,7 +26,7 @@ import ( | |||
| "google.golang.org/grpc/resolver" | |||
| ) | |||
|
|
|||
| // NewBuilderWithScheme creates a new test resolver builder with the given scheme. | |||
| // NewBuilderWithScheme creates a new manual resolver builder with the given scheme. | |||
There was a problem hiding this comment.
Should we document that this may only be used with a single ClientConn? Otherwise bad things happen.
dfawley
approved these changes
Sep 15, 2023
| // NewBuilderWithScheme creates a new manual resolver builder with the given scheme. | ||
| // NewBuilderWithScheme creates a new manual resolver builder with the given | ||
| // scheme. Every instance of the manual resolver may only ever be used with a | ||
| // single grpc.ClientConn. Otherwise, bad things will happen. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: none