xdsclient: completely remove the old WatchCluster API #6621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Sep 14, 2023
| } | ||
|
|
||
| func (ew *clusterWatcher) OnError(err error) { | ||
| ew.updateCh.SendOrFail(xdsresource.ClusterUpdateErrTuple{Err: err}) |
There was a problem hiding this comment.
Why does this SendOrFail where as API you switched from Sends on all? Can you switch this to blocking and assert it doesn't receive an error from updateCh? I don't really care, but can you comment here or top level for clusterWatcher if this route as to why one send blocks and one doesnt?
There was a problem hiding this comment.
I actually wanted to use Replace, which is what I had used in the xds_resolver_test. This block of code, I just copied over from the endpointsWatcher. Changed both to use Replace instead and added a comment as well. Thanks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6600 switched the CDS LB policy to use the new API to watch a cluster. This PR:
xdsclient.XDSClientinterfacefakeclientpackagexdsclient.clientImpltype#resource-agnostic-xdsclient-api
RELEASE NOTES: none