test: speed up two tests #6558
Merged
test: speed up two tests #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TestFlowControlLogicalRace: reduce some of the stressiness of this test to make it run in ~1s vs. ~4s before. - TestCZClientSocketMetricsKeepAlive: make the keepalive pings happen at a much higher rate to enable two pings to happen in 100ms vs. 2s. Update test condition to pass even if verifyResultWithDelay needs to sleep a few times (this shouldn't happen, but could in theory).
arvindbr8
approved these changes
Aug 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestFlowControlLogicalRace: reduce some of the stressiness of this test to make it run in ~1s vs. ~4s before. Also make some minor simplifications to remove 10 lines of code and have the same logic.TestCZClientSocketMetricsKeepAlive: make the keepalive pings happen at a much higher rate to enable two pings to happen in 100ms vs. 2s. Update test condition to pass even ifverifyResultWithDelayneeds to sleep a few times (this shouldn't happen, but could in theory).RELEASE NOTES: none