grpctest: use an interface instead of reflection #6553
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was originally going to try to see if I could use generics to set a
context.Context
field in theTester
embedded in the struct so that every test case could automatically get our default deadline (and we could even forbidcontext.Background()
from being called from tests). But, in practice we declare test methods without receivers, e.g.:So the only way to do that would require a change to:
At which point, we might just be better off doing:
But regardless of any of that, I found a simple cleanup to use an interface instead of reflection to find the
Setup
andTeardown
methods, which at one point (before we started overriding the logger) were optional.RELEASE NOTES: n/a