xds/outlierdetection: Stop handling UpdateSubConnState forwarding #6520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Aug 9, 2023
| @@ -1387,11 +1385,6 @@ func (s) TestConcurrentOperations(t *testing.T) { | |||
| t.Error("ResolverError was called after Close(), which breaks the balancer API") | |||
| } | |||
| }, | |||
| UpdateSubConnState: func(*stub.BalancerData, balancer.SubConn, balancer.SubConnState) { | |||
| if closed.HasFired() { | |||
| t.Error("UpdateSubConnState was called after Close(), which breaks the balancer API") | |||
There was a problem hiding this comment.
I'm assuming state listeners still follow this API (can't be called after close)?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All children use
StateListener, so this fallback path is no longer needed. Update tests accordingly, too.RELEASE NOTES: none