test: clean up deadlines set in tests #6506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A straw finally broke the camel's back. Many of our tests don't set timeouts and hang for minutes. This change fixes them, and also standardizes on the use of
defaultTest[Short]Timeout
everywhere. My goal is to eventually put something like this intovet.sh
to make it never happen again:There are currently 130 left in our entire tree. Some of these will need to be exempted somehow, or reworked a little to first create a
ctx
with a timeout and then shorten it from there.We probably also should look out for
select
s without a context, bare reads from channels, andany wg.Wait()
calls.RELEASE NOTES: none