Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clusterresolver: add logs for dns discovery mechanism error cases #6444

Merged
merged 1 commit into from
Jul 13, 2023
Merged

clusterresolver: add logs for dns discovery mechanism error cases #6444

merged 1 commit into from
Jul 13, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jul 12, 2023

Ran into the absence of these logs when debugging a directpath issue. We currently have such logs for the EDS discovery mechanism which were recently added.

RELEASE NOTES: none

@easwars easwars requested a review from zasweq July 12, 2023 21:05
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jul 12, 2023
@easwars easwars added this to the 1.57 Release milestone Jul 12, 2023
@easwars
Copy link
Contributor Author

easwars commented Jul 12, 2023

@zasweq : want to sneak this one in before you complete working on the empty priority issue :)

zasweq
zasweq approved these changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

xds/internal/balancer/clusterresolver/resource_resolver_dns.go Show resolved Hide resolved
@zasweq zasweq removed their assignment Jul 12, 2023
@easwars easwars merged commit d1868a5 into grpc:master Jul 13, 2023
1 check passed
@easwars easwars deleted the improve_dns_discovery_mechanism_logs branch July 13, 2023 00:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.57 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @zasweq