xds/internal/balancer/clusterimpl: Switch cluster impl child to graceful switch #6420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Jun 30, 2023
| if b.childLB != nil { | ||
| b.childLB.Close() | ||
| if err := b.child.SwitchTo(bb); err != nil { | ||
| return fmt.Errorf("cluster impl: error switching to child of type %q: %v", newConfig.ChildPolicy.Name, err) |
There was a problem hiding this comment.
Nit: The existing error strings don't have a prefix of cluster impl. My preference would be to stay consistent with existing code or switch them all. And even if you switch, I would think the prefix would be clusterimpl and not cluster impl.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6170. Cluster Impl was implemented before there was a graceful switch balancer object, and thus did not have it's child as a Graceful Switch. The child of cluster impl can be dynamic over the lifetime of the xDS tree based off locality + endpoint picking configuration for a priority, so this is a fairly common use case that will be better served with graceful switch functionality present.
RELEASE NOTES: N/A