reflection: expose both v1 and v1alpha reflection services #6329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Jun 9, 2023
dfawley
changed the title
zasweq
approved these changes
Jun 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5684.
This adds
RegisterV1andRegisterV1Alphato provide control over the versions registered. The existingRegisterfunction registers both versions.This also adds
NewServerV1to return a server that implements the new version.NewServercontinues to return the v1alpha version of the interface.All of the core logic and types have been updated to refer to the newer definitions in v1. Adapters have been added, to convert between v1 and v1alpha, to provide the v1alpha server. The adapters are also used in tests, so that the end-to-end tests now go through both v1 and v1alpha stubs, to verify both versions work correctly.
RELEASE NOTES: