*: add missing colon to errorf messages to improve readability #5911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests pass locally for me, I think it's a flaky test. Cannot rerun the action - no permissions. |
arvindbr8
approved these changes
Jan 9, 2023
| @@ -118,9 +118,10 @@ func main() { | |||
| // If -secure_mode is not set, expose all services on -port with a regular | |||
| // gRPC server. | |||
| if !*secureMode { | |||
| lis, err := net.Listen("tcp4", fmt.Sprintf(":%d", *port)) | |||
| addr := fmt.Sprintf(":%d", *port) | |||
There was a problem hiding this comment.
nit: maybe init addr above this block and nix line 145?
There was a problem hiding this comment.
I wanted to preserve the "laziness" of formatting, if that's ok.
|
I'm also seeing more errors which seems to have been formatted with the missing colon. Wondering if we should sweep the repo with a regex grep to help us locate all of them. |
arvindbr8
changed the title
|
That's what I did - regex, but also checked some function usage manually. I certainly may have missed some places - there is a lot of code. |
easwars
requested changes
Jan 10, 2023
easwars
approved these changes
Jan 18, 2023
|
Thank you very much for your contribution !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly add missing colons but also address few other minor issues.
It's confusing to read an error message without a colon for nesting, so that was the main motivation for the change. Happened to me couple of times and I couldn't find the whole string anywhere in code, wasted some time on it.
RELEASE NOTES: