transport: simplify httpClient by moving onGoAway func to onClose #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Dec 21, 2022
easwars
reviewed
Dec 29, 2022
| @@ -1290,8 +1291,10 @@ func (t *http2Client) handleGoAway(f *http2.GoAwayFrame) { | |||
| // Notify the clientconn about the GOAWAY before we set the state to | |||
| // draining, to allow the client to stop attempting to create streams | |||
| // before disallowing new streams on this connection. | |||
| t.onGoAway(t.goAwayReason) | |||
| t.state = draining | |||
| if t.state != draining { | |||
There was a problem hiding this comment.
Is this a behavior change that needs to be release noted?
There was a problem hiding this comment.
There should be no user-visible behavior change here, because of the corresponding changes in grpc's usage of the transport.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff simplifies the transport code a little by removing onGoAway func and moving the logic into onClose. Updating tests to remove the onGoAway param
RELEASE NOTES: none