reflection: generate protobuf files from grpc-proto #5799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
approved these changes
Nov 17, 2022
|
@dfawley : For second set of eyes. |
dfawley
approved these changes
Nov 21, 2022
dfawley
changed the title
camh-
pushed a commit
to foxygoat/jig
that referenced
this pull request
Mar 12, 2023
Update our dependencies to be compatible with the current latest release
of `google.golang.org/genproto` by running:
go get google.golang.org/genproto
go mod tidy
This has broken a couple of small things, which are fixed here:
* The generated var name for the embedded protobuf descriptors has
changed, so when `google.golang.org/grpc` got updated due to the
genproto update, `reflection/service.go` needed to be updated with
the new name. This was changed in grpc/grpc-go#5799.
The var name changed because its proto import changed as part of that
PR, and the var name is based on the import name.
* The error message for when `SendHeader` is called multiple times on a
stream has changed which broke a test that was testing the error type
and string. This was changed upstream in grpc/grpc-go#5292.
Link: grpc/grpc-go#5799
Link: grpc/grpc-go#5292
Pull-Request: #47
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update regenerate.sh (which creates the generated protobuf go files in the repo) to instead pull the proto files from grpc/grpc-proto and remove the cached copies of the proto files.
Now, generated files are sourced from the v1alpha and v1 versions.
RELEASE NOTES: none