Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: Restore deps and testdeps #4060

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Nov 24, 2020

No description provided.

@dfawley dfawley assigned easwars and unassigned dfawley Nov 24, 2020
@easwars easwars merged commit 53c8623 into grpc:master Nov 24, 2020
@easwars easwars deleted the restore_make branch November 24, 2020 19:56
@jtattermusch
Copy link
Contributor

@easwars thanks for the revert.
It looks like the go interop build is still broken though, so perhaps more needs to be reverted.
https://source.cloud.google.com/results/invocations/47a57608-f03b-4882-80ef-c35fd801af5a/targets/github%2Fgrpc%2Finterop_docker_build/tests

@dfawley
Copy link
Member

dfawley commented Nov 30, 2020

$ GO111MODULE=on go get -d -v google.golang.org/grpc/...

<Seems fine>

GO111MODULE=on go get -d -v -t google.golang.org/grpc/...
go get: -t flag is a no-op when using modules
../../credentials/credentials.go:31:2: cannot find package "github.com/golang/protobuf/proto" in any of:
	/usr/local/go/src/github.com/golang/protobuf/proto (from $GOROOT)
	/go/src/github.com/golang/protobuf/proto (from $GOPATH)
...
...
...

I can't explain this. The first go get doesn't say it's downloading this package. But there are some packages it says it downloaded that the second go get fails to find.

Why is it looking in ...go/src though? With modules, it uses $GOPATH/pkg. I think even with this the go installs in the interop script are going to need GO111MODULE=on: grpc/grpc#24831, at which point the deps targets shouldn't actually be necessary. So maybe this PR wasn't needed after all.

@jtattermusch
Copy link
Contributor

Also see b/174073491 for some extra details (build_docker_go is still broken on master).

davidkhala pushed a commit to Hyperledger-TWGC/grpc that referenced this pull request Dec 7, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants