internal: clean up all usages of grpclog, and replace with component #3719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Jul 1, 2020
There was a problem hiding this comment.
Also, would it make sense to add a README somewhere, probably in grpclog directory that lists the available components. Or maybe directly add something in https://github.com/grpc/grpc-go/blob/master/Documentation/log_levels.md to talk about component logging.
menghanl
force-pushed
the
logging_component_only
branch
from
c2c90d9 to
6233954
Compare
easwars
requested changes
Jul 30, 2020
There was a problem hiding this comment.
Reviewed 36 of 36 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dfawley and @menghanl)
credentials/sts/sts.go, line 65 at r1 (raw file):
readSubjectTokenFrom = ioutil.ReadFile readActorTokenFrom = ioutil.ReadFile logger = grpclog.Component("sts")
Do we need a separate component for STS? Can't it use the "credentials" component?
|
Looks good to me except for the "sts" component. |
easwars
approved these changes
Jul 30, 2020
menghanl
force-pushed
the
logging_component_only
branch
from
f9475e5 to
c648d2d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.