Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis/Makefile/vet cleanups #2283

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Travis/Makefile/vet cleanups #2283

merged 2 commits into from
Sep 4, 2018

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Aug 31, 2018

  • .travis.yml:
    • Download dependencies at install time
    • Run race and non-race in separate instances
    • Use braces around env var names
  • vet.sh:
    • Run go mod tidy to keep it tidy
    • Stop filtering transport errors from go/vet output
    • Use braces around env var names
  • Makefile:
    • Reorder alphabetically
    • Add "vetdeps" as a dependency of "vet"
    • Add "testappengine" to "all"

@dfawley
- run race test in its own instance
43a24ed 
- download dependencies appropriately
- run go mod tidy in vet.sh
- Makefile cleanup
- stop filtering vet output
@dfawley dfawley added the Type: Internal Cleanup Refactors, etc label Aug 31, 2018
@dfawley dfawley merged commit ba4eb68 into grpc:master Sep 4, 2018
@dfawley dfawley deleted the trav_cleanup branch September 4, 2018 22:10
dfawley added a commit to dfawley/grpc-go that referenced this pull request Sep 12, 2018
@dfawley
Travis/Makefile/vet cleanups (grpc#2283)
17676ae 
- .travis.yml:
  - Download dependencies at install time
  - Run race and non-race in separate instances
  - Use braces around env var names
- vet.sh:
  - Run `go mod tidy` to keep it tidy
  - Stop filtering transport errors from go/vet output
  - Use braces around env var names
- Makefile:
  - Reorder alphabetically
  - Add "vetdeps" as a dependency of "vet"
  - Add "testappengine" to "all"
@lock lock bot locked as resolved and limited conversation to collaborators Mar 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl