Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health: generate health proto from grpc-proto #2081

Merged
merged 2 commits into from
May 17, 2018
Merged

health: generate health proto from grpc-proto #2081

merged 2 commits into from
May 17, 2018

Conversation

carl-mastrangelo
Copy link
Contributor

PTAL @MakMukhi

@carl-mastrangelo
Copy link
Contributor Author

Same idea as #2056

@menghanl
Copy link
Contributor

The change in this PR won't be tested on travis because make proto only runs in cron jobs.

Can you make a change (59431fb) to force travis to run the tests? This change will need to be removed before merging.

@menghanl
Copy link
Contributor

The build failure was fixed by #2085. Please rebase and try again. Thanks!

@carl-mastrangelo
Copy link
Contributor Author

@menghanl done

menghanl
menghanl approved these changes May 17, 2018
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the test change... Thanks!

@carl-mastrangelo
Copy link
Contributor Author

@menghanl done

@menghanl
Copy link
Contributor

@carl-mastrangelo Thanks!

@menghanl menghanl merged commit 3b7feb1 into grpc:master May 17, 2018
@menghanl menghanl added the Type: Internal Cleanup Refactors, etc label May 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carl-mastrangelo @menghanl