Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: extend dial context for test to 10 seconds #1984

Merged
merged 1 commit into from
Apr 12, 2018
Merged

cleanup: extend dial context for test to 10 seconds #1984

merged 1 commit into from
Apr 12, 2018

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Apr 10, 2018 •
edited
Loading

for TestFailFastRPCErrorOnBadCertificates

We were getting context deadline exceeded from this dial, but the dial is not blocking.

updates #1968

@menghanl menghanl changed the title cleanup: extend dial context to 10 seconds cleanup: extend dial context for test to 10 seconds Apr 10, 2018
@MakMukhi MakMukhi merged commit 0c6b34b into grpc:master Apr 12, 2018
@menghanl menghanl deleted the dial_10_seconds branch April 12, 2018 22:50
@lock lock bot locked as resolved and limited conversation to collaborators Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MakMukhi MakMukhi MakMukhi approved these changes

Assignees

@MakMukhi MakMukhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @MakMukhi