Check "x/net/context" with go vet like "context"
#1490
Conversation
Includes a signficant revamp of .travis.yml to execute a separate script for all of the things we check before allowing a merge.
vet.sh
Outdated
| trap cleanup EXIT | ||
|
|
||
| # Only run these tests on Go 1.8 or manually. | ||
| if [[ "$TRAVIS" = "true" && "$TRAVIS_GO_VERSION" != 1.8* ]]; then |
There was a problem hiding this comment.
We are going to change this to 1.9* shortly.
I wonder if there's an easy way to find what the latest go version is...
There was a problem hiding this comment.
I could find no way.
Since this requires coordination with .travis.yml, how about let's make the script run unconditionally in travis but only launch it conditionally on the version?
| @@ -20,7 +20,6 @@ proto: | |||
| echo "error: protoc not installed" >&2; \ | |||
| exit 1; \ | |||
| fi | |||
| go get -u -v github.com/golang/protobuf/protoc-gen-go golang.org/x/tools/cmd/stringer | |||
There was a problem hiding this comment.
Should we keep this?
Though this works on travis, someone trying to run make proto locally may fail because of these two missing packages...
There was a problem hiding this comment.
I'm fine with reverting this, but then we should change make proto in vet.sh to run go generate. Otherwise you end up with the latency of go get every time you run vet.sh, which is not really desirable.
Alternatively, we can check $GOPATH/..... for these two things and fail with a friendlier error if they are not found.
Thoughts?
* Check "x/net/context" with `go vet` like "context" Includes a signficant revamp of .travis.yml to execute a separate script for all of the things we check before allowing a merge. * fix bug in benchmain
Includes a signficant revamp of .travis.yml to execute a separate script for
all of the things we check before allowing a merge.
Fixes #1484