Skip to content

Possible regression when using NewClient instead of Dial #7075

Closed
@arvindbr8

Description

#7029 introduced the NewClient() API which should potentially replace grpc.Dial()

However in this branch, when I updated the orca example to use NewClient I'm seeing an error on the client side.

2024/04/02 13:24:29 Error from UnaryEcho call: rpc error: code = DeadlineExceeded desc = context deadline exceeded

This needs investigation, and possibly prioritization before the next release this week

Activity

self-assigned this
on Apr 2, 2024
arvindbr8

arvindbr8 commented on Apr 2, 2024

@arvindbr8
MemberAuthor

this is an issue with the way the orcaLB is setup. The UpdateClientConnState method was asserting that the resolver returns only 1 address. this was true in the case of passthrough, however since NewClient uses dns as default schema the resolver returned two addresses in Github VM (and in my local machine) - 1 ipv4 and 1 ipv6 address. This is not a regression.

locked as resolved and limited conversation to collaborators on Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions

    Possible regression when using NewClient instead of Dial · Issue #7075 · grpc/grpc-go