Skip to content

Commit

Permalink
cmd/protoc-gen-go-grpc: remove replace and skip test that requires it…
Browse files Browse the repository at this point in the history
… for now (#7451)
  • Loading branch information
dfawley authored Jul 29, 2024
1 parent 3eb0145 commit 245323c
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
2 changes: 0 additions & 2 deletions cmd/protoc-gen-go-grpc/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,3 @@ require (
golang.org/x/text v0.16.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117 // indirect
)

replace google.golang.org/grpc => ../..
2 changes: 2 additions & 0 deletions cmd/protoc-gen-go-grpc/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,7 @@ golang.org/x/text v0.16.0 h1:a94ExnEXNtEwYLGJSIUxnWoxoRz/ZcCsV63ROupILh4=
golang.org/x/text v0.16.0/go.mod h1:GhwF1Be+LQoKShO3cGOHzqOgRrGaYc9AvblQOmPVHnI=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117 h1:1GBuWVLM/KMVUv1t1En5Gs+gFZCNd360GGb4sSxtrhU=
google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117/go.mod h1:EfXuqaE1J41VCDicxHzUDm+8rk+7ZdXzHV0IhO/I6s0=
google.golang.org/grpc v1.65.0 h1:bs/cUb4lp1G5iImFFd3u5ixQzweKizoZJAwBNLR42lc=
google.golang.org/grpc v1.65.0/go.mod h1:WgYC2ypjlB0EiQi6wdKixMqukr6lBc0Vo+oOgjrM5ZQ=
google.golang.org/protobuf v1.34.1 h1:9ddQBjfCyZPOHPUiPxpYESBLc+T8P3E+Vo4IbKZgFWg=
google.golang.org/protobuf v1.34.1/go.mod h1:c6P6GXX6sHbq/GpV6MGZEdwhWPcYBgnhAHhKbcUYpos=
3 changes: 3 additions & 0 deletions cmd/protoc-gen-go-grpc/unimpl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,16 @@ type unimplEmbeddedByValue struct {
}

func TestUnimplementedEmbedding(t *testing.T) {
t.Skip("Skip until next grpc release includes panic during registration.")

// Embedded by value, this should succeed.
testgrpc.RegisterTestServiceServer(grpc.NewServer(), &unimplEmbeddedByValue{})
defer func() {
if recover() == nil {
t.Fatalf("Expected panic; received none")
}
}()

// Embedded by pointer, this should panic.
testgrpc.RegisterTestServiceServer(grpc.NewServer(), &unimplEmbeddedByPointer{})
}

0 comments on commit 245323c

Please sign in to comment.