strcmp: change all !str[n]cmp to str[n]cmp == 0 #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change all !str[n]cmp to be str[n]cmp == 0 consistently across the codebase. Issue #231 Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
|
I think I addressed all the issues raised in #977
|
|
Awesome, thank you so much! Closes #231. By the way, you don't need to close and re-open the pull request every time you want to further improve it. You can continue pushing to your branch or even rebase it. Github will amend the pull request accordingly. |
nicolasnoble
added a commit
that referenced
this pull request
Mar 8, 2015
strcmp: change all !str[n]cmp to str[n]cmp == 0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change all !str[n]cmp to be str[n]cmp == 0 consistently across the codebase.
Issue #231
Signed-off-by: Ronnie Sahlberg ronniesahlberg@gmail.com