Added timeout for tests that hang #972
Conversation
Added prettier cloud to prod output and a history of results
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. |
| @@ -797,7 +797,26 @@ grpc_interop_test() { | |||
| echo " $ssh_cmd" | |||
| echo "on $host" | |||
| [[ $dry_run == 1 ]] && return 0 # don't run the command on a dry run | |||
| gcloud compute $project_opt ssh $zone_opt $host --command "$cmd" | |||
| gcloud compute $project_opt ssh $zone_opt $host --command "$cmd" & | |||
There was a problem hiding this comment.
A little comment that describes what this is doing would be nice. Also, you have virtually the same logic here twice, so how about providing a function that does the waiting and killing magic and and a docline for it?
|
Please take another look thank you! |
Added timeout for tests that hang
Added prettier cloud to prod output and a history of results