Hookup TSI tracer #908
Merged
Hookup TSI tracer #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/core/tsi/ssl_transport_security.c
First: ugh. Second: allow tracer global variables to be registered and then parsed out of a configuration environment variable. Expose TSI trace config variable directly to ease this a little.
|
@nicolasnoble - the separated init that we talked about is here. |
| @@ -63,8 +63,8 @@ const char* tsi_result_to_string(tsi_result result); | |||
|
|
|||
| /* --- tsi tracing --- */ | |||
|
|
|||
| /* Call this function before any other tsi function to avoid races. */ | |||
| void tsi_enable_tracing(void); | |||
| /* set this early to avoid races */ | |||
|
I'm good with the changes. Assigning to @nicolasnoble if he wants to have a look. Otherwise, I'm happy to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First: ugh.
Second: allow tracer global variables to be registered and then parsed out of a configuration environment variable.
Expose TSI trace config variable directly to ease this a little.