Revert "Revert "Revert "Revert "Remove redundant includes from string.h and tmpfile.h"""" #9064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….h and tmpfile.h""""
sreecha
approved these changes
Dec 12, 2016
|
This PR seems to be out of date: there are mentions of gpr_slice and reintroduction of slice.h, etc. |
|
@dgquintas , this is not outdated. It was deliberately added to maintain backward compatibility with any third party sources (like tensorflow) that take a dependency on grpc release snapshots. This can be released once we cut another grpc release |
|
ah, got it, thanks @sreecha ! |
|
Who has the next action on this PR? @markdroth? |
|
I will drive this forward, but there's nothing that can really be done with it until the moratorium on build changes is lifted. |
…t-8951-revert-8949-revert-8922-slice_cleanup
…t-8951-revert-8949-revert-8922-slice_cleanup
sreecha
approved these changes
Jan 13, 2017
…t-8951-revert-8949-revert-8922-slice_cleanup
|
Known failures: #8996. |
markdroth
deleted the
revert-9063-revert-8951-revert-8949-revert-8922-slice_cleanup
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #9063. Yet another attempt to get #8922 to stick.
Trying this one more time.
NOTE: DO NOT MERGE UNTIL AFTER BUILD CHANGE MORATORIUM IS OVER!