Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker go #8845

Merged
merged 1 commit into from
Nov 23, 2016
Merged

Fix docker go #8845

merged 1 commit into from
Nov 23, 2016

Conversation

ncteisen
Copy link
Contributor

@ncteisen ncteisen commented Nov 23, 2016 •
edited
Loading

Changed "go get -t ." to "make deps && make testdeps"

This is a more accurate way to pull in all of the needed dependancies.

This closes #8844

jtattermusch
jtattermusch approved these changes Nov 23, 2016
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@ncteisen ncteisen merged commit bae24c7 into grpc:master Nov 23, 2016
@ncteisen ncteisen deleted the fix_docker_go branch November 23, 2016 21:04
@ncteisen ncteisen mentioned this pull request Dec 8, 2016
Closed
@apolcyn apolcyn mentioned this pull request Dec 9, 2016
Merged
This was referenced Dec 9, 2016
Merged
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
area/interop cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go Docker is Broken
3 participants
@ncteisen @jtattermusch @googlebot