Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_projects.sh out of sync on master #8271

Merged
merged 1 commit into from
Oct 4, 2016
Merged

generate_projects.sh out of sync on master #8271

merged 1 commit into from
Oct 4, 2016

Conversation

stanley-cheung
Copy link
Contributor

I couldn't quite track it down how this got out of sync. But it seems to happen some where around Sept 27 according to Jenkins.

jtattermusch
jtattermusch approved these changes Oct 4, 2016
View reviewed changes
Copy link
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is because of #8202.

LGTM (tests pending).

@stanley-cheung stanley-cheung merged commit db1f7bc into grpc:master Oct 4, 2016
@stanley-cheung stanley-cheung deleted the master-generate-projects-out-of-sync branch October 4, 2016 19:36
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jtattermusch jtattermusch jtattermusch approved these changes

Assignees

@jtattermusch jtattermusch

Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stanley-cheung @jtattermusch @googlebot