Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for creating insecure channel from FD with custom arguments using C++ API. #8046

Merged
merged 1 commit into from
Sep 29, 2016

Conversation

gislan
Copy link
Contributor

@gislan gislan commented Sep 9, 2016

This was already supported in C API.

using C++ API.

This was already supported in C API.
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

@gislan
Copy link
Contributor Author

gislan commented Sep 15, 2016

@ctiller would you mind taking a look at this?

Copy link
Member

@ctiller ctiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gislan
Copy link
Contributor Author

gislan commented Sep 16, 2016

What's the next step here? Someone with admin powers needs to tell Jenkins to run test?

@ctiller
Copy link
Member

ctiller commented Sep 20, 2016

Jenkins: test this please

@gislan
Copy link
Contributor Author

gislan commented Sep 21, 2016

Hmm...none of those failures seem related to my change. One of them is:
/bin/bash: rvm: command not found
The command '/bin/sh -c /bin/bash -l -c "rvm install ruby-2.1"' returned a non-zero code: 127
Traceback (most recent call last):
File "tools/run_tests/run_tests.py", line 1126, in
env=env)
File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['tools/run_tests/dockerize/build_docker_and_run_tests.sh']' returned non-zero exit status 127

Another one is some kind of benchmark that doesn't even call the method I'm adding here.

Is it possible these tests are just flaky?

@gislan
Copy link
Contributor Author

gislan commented Sep 26, 2016

@ctiller @yang-g Do you agree that the failures are flakes / unrelated? How do I proceed?

@yang-g yang-g merged commit d24b822 into grpc:master Sep 29, 2016
@yang-g
Copy link
Member

yang-g commented Sep 29, 2016

The tests look like flaky to me.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants