Dotnet CLI distrib tests and associated cleanup. #8039
Conversation
|
Based on my grabbing the packages build by jenkins and running distribtests manually with them, it seems that the all the tested scenarios with dotnetcli now work. the distribtest csharp_nuget_linux_x64_centos7 doesn't pass, but actually before this PR all the distribtests seemd to be broken (because of the nuget update -self) |
|
Tests seem green. |
|
Sorry I'm just re-checking the non-passing centos distrib test, as I did see distrib tests passing earlier (when they were updated to System.Interactive.Async dependency, ran the nuget update -self and saw them pass in #7729). Re-ran a build on v1.0.x just to check distrib tests, at https://grpc-testing.appspot.com/job/gRPC_build_artifacts/1712/ |
|
+1 to double checking stuff (but if the distrib tests pass, I'd be very surprised). |
|
LGTM |
-- cleanup of project.json files (get rid of runtimes declaration thanks to importing Microsoft.NETCore.App with "type": "platform")
-- fixes in run_tests.py to run tests build by dotnet cli correctly
-- add a distribtest that tests
dotnet buildanddotnet publishfor bothnet45andnetcoreapp1.0-- (hopefully) fix
dotnet publishonnetcoreapp1.0by adding a search path for the native extension.-- enable building all nugets on linux (under docker) and zip them.
-- in distribtests, update nuget to 2.12 so that Grpc.sln can be restored.
Note: By default, the distribtests still run for the old way of building nuget packages (that will be changed in a followup PR if things go well).
Tentative fix for #8012.