prep work for enabling caching #7862
Conversation
Added new header grpc-payload-bin Added new channel arg for setting max payload size Ability to create a GET request in client filter Ability to parse the payload from header in server filter.
|
|
||
| if (method == GRPC_MDELEM_METHOD_GET) { | ||
| gpr_slice slice; | ||
| /* TODO (makdharma): extend code for messages with multiple slices */ |
There was a problem hiding this comment.
Needs to be completed before submission
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
freeing up payload_bytes. returning GET response only once.
|
test this please |
|
@nicolasnoble Test failures look like a flake, could you please confirm and LGTM if so? |
|
I don't have a clear idea as to why clang-format seems to have lost its head here and is fighting with itself. We've been taking precautions to make sure we are sticking on a very specific version of it for this exact reason. |
|
|
||
| /* Decide which HTTP VERB to use */ | ||
| grpc_mdelem *method = GRPC_MDELEM_METHOD_POST; | ||
| if (op->send_initial_metadata != NULL && (op->send_initial_metadata_flags & |
There was a problem hiding this comment.
Comment that we need both send initial metadata and the first send in the same batch (for now) to enable GET
modified comment about when GET verb is used. Added code to read data from send_message and defer the op when it is not fully available. clang-format one more time.
| cacheable, and the operation contains both initial metadata and send message, | ||
| and the payload is below the size threshold, and all the data | ||
| for this request is immediately available. */ | ||
| grpc_mdelem *method = GRPC_MDELEM_METHOD_POST; |
There was a problem hiding this comment.
This whole block (up until line 261) could probably go into an if (op->send_initial_metadata) right?
That way we'd skip doing some complicated processing on other code paths (like, say, recv_initial_metadata)
moved method computation in a if block only when send_initial_metadata is true.
|
LGTM |
Added new header grpc-payload-bin
Added new channel arg for setting max payload size
Ability to create a GET request in client filter
Ability to parse the payload from header in server filter.