throw grpc failed instead of invalid op on generic failure #7861
Conversation
|
What can cause these failures? They sound like IOExceptions just from a brief look at the code throwing them. But yes, that would be a breaking change... |
|
It gets tricky I think because it looks like it can be thrown for invalid operation programming errors (e.g., calling |
|
It seems like extending the current exception would be too much of a breaking change? Closing this to not use the idea, guessing it might just cause problems. |
| using System; | ||
| namespace Grpc.Core | ||
| { | ||
| public class GrpcOperationFailedException : InvalidOperationException |
There was a problem hiding this comment.
FTR, we actually uses to have a similar exception type in a way earlier version of gRPC C# (pre-alpha), but then got rid of it.
It looks like there's been some desire to change the use of invalid operation exception on certain failures.
Making and throwing a new type here that extends InvalidOperationException to not make a breaking change. (under assumption users might currently
catch InvalidOperationException).This is mostly an initial idea to change it. I doesn't seem common to extend something other than Exception. Another idea was adding something new as the inner exception of InvalidOperationException, but seeing how this looked.
cc @jtattermusch @jskeet