Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove undefined env #7854

Merged
merged 1 commit into from
Sep 1, 2016
Merged

Remove undefined env #7854

merged 1 commit into from
Sep 1, 2016

Conversation

pythias
Copy link
Contributor

@pythias pythias commented Aug 24, 2016

Without determine_extension_dir.sh, $extension_dir is not define yet.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

1 similar comment
@grpc-kokoro
Copy link

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok to test.

@stanley-cheung stanley-cheung self-assigned this Aug 25, 2016
@stanley-cheung
Copy link
Contributor

Thanks for the contribution

@stanley-cheung stanley-cheung merged commit 463ff57 into grpc:master Sep 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@stanley-cheung stanley-cheung

Labels
cla: yes lang/php
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pythias @grpc-kokoro @stanley-cheung @googlebot