remove dedicated thread for ruby bidi read loop #7669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apolcyn
force-pushed
the
reduce_bidi_threads_ga
branch
from
636b9e5 to
dc3d561
Compare
|
latest forced update removes the update to protobuf submodule |
|
LGTM |
|
python to ruby-server interop cancel_after_begin test hit a gpr_assert. This test in itself shouldn't have been touched by this PR, which only affects bidi calls, not sure if this is a real error. |
|
I have seen a few instances of "python client to something server" failures recently with similar errors. I don't think that error is related to this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the extra thread for the read loop on bidi calls, which used to read and push onto a queue that would be popped from in the handler. This changes the enumerator of remote reads to do a remote read on every #next.
This seemed to have good performance results. Testing on a single 8-core, 30gb host, this had about 25% decrease/increase in latency/qps for constrained streaming, and about 15 to 20% for unconstrained streaming.