Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed census static metadata keys for tracing and tag propagation #7601

Merged
merged 1 commit into from
Aug 2, 2016

Conversation

dgquintas
Copy link
Contributor

@dgquintas dgquintas commented Aug 2, 2016

On behalf of @bogdandrutu

@pgrosu
Copy link

pgrosu commented Aug 2, 2016

Unless I'm mistaken, isn't @bogdandrutu also doing a similar thing via #6877?

@dgquintas
Copy link
Contributor Author

Apparently. I did this with @bogdandrutu right by my side (ie, on his behalf), so I'll let him comment on the duplication.

@bogdandrutu
Copy link

I marked that as a DO NOT SUBMIT and throw it away.

@pgrosu
Copy link

pgrosu commented Aug 2, 2016

Well that simplifies things :) Thanks Bogdan and David.

@kpayson64 kpayson64 merged commit 52f3b67 into grpc:master Aug 2, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants