Update .NET core dependencies to RTM #7580
Conversation
|
@jskeet please take a quick look as well. |
jtattermusch
changed the title
| @@ -34,9 +34,9 @@ | |||
| "net45" | |||
| ], | |||
| "dependencies": { | |||
| "Microsoft.NETCore.Portable.Compatibility": "1.0.1-rc2-24027", | |||
There was a problem hiding this comment.
Since we still work with the earlier versions of these libraries, wondering why we update them, just for their internal changes?
There was a problem hiding this comment.
The rc2-24027 are prerelease versions, it makes sense to update to their GA versions (no particular reason, I just think it makes sense to update to stable dependencies once they are available).
|
Since these changes should probably get used in #7519, if it gets used, I think this would be helpful in this branch. |
| @@ -53,7 +53,7 @@ internal static class PlatformApis | |||
|
|
|||
| static PlatformApis() | |||
| { | |||
| #if NETSTANDARD1_5 | |||
| #if !NET45 | |||
There was a problem hiding this comment.
The tests now seem to be unable to find RuntimeInformation. Possibly building on a later .NET version?
There was a problem hiding this comment.
If someone were to run on net451, but use Grpc net45 target, would this break? E.g., something like:
frameworks: { net451: { imports: net45 } }, (If net451 doesn't automatically import net45?)
There was a problem hiding this comment.
*realizing nugets already built
|
I'm in transit to Sydney with family. Will look when I can, but it won't be On 30 Jul 2016 4:23 a.m., "Jan Tattermusch" notifications@github.com
|
|
Have a great trip Jon! I'll be more gentle when testing 1.0.0-pre1 for C# :) Enjoy and have fun! |
jtattermusch
force-pushed
the
netcore_nuget_to_rtm
branch
from
a1bd716 to
0a5a0ca
Compare
|
Fixed some issues introduces when changing PTAL (hopefully the tests will pass now). |
| @@ -12,12 +12,13 @@ | |||
| }, | |||
| "frameworks": { | |||
| "net45": { }, | |||
| "netstandard1.5": { | |||
| "netcoreapp1.0": { | |||
| "imports": [ | |||
| "portable-net45" | |||
There was a problem hiding this comment.
not super clear on how the framework importing is working, I take it this import still works since netcoreapp1.0 implements the netstandard1.5 anyways?
|
Tests are green. |
|
Yay! |
|
Will this part of the 1.0.x prerelease? |
|
LGTM |
|
I believe this will be in a later 1.0.x-pre, @pgrosu |
|
Thanks @apolcyn |
|
It's beautifully green, so merging. (CC @kpayson64) |
Fixes #7334
Basically, this updates the dependencies and switches some projects of type "application" to netcoreapp1.0.
I am not sure if this should still go in the GA branch or to master branch (it's a nice-to-have fix, but it doesn't have any user-visible impact at this point).